Skip to content

fix nightly tests #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix nightly tests #830

merged 1 commit into from
Dec 18, 2023

Conversation

Dr-Irv
Copy link
Collaborator

@Dr-Irv Dr-Irv commented Dec 18, 2023

Had failures as of 12/18, so this fixes them.

@Dr-Irv Dr-Irv requested a review from twoertwein December 18, 2023 16:47
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mac failures might be a pandas bug (or an issue of a pandas dependency)?

@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Dec 18, 2023

The mac failures might be a pandas bug (or an issue of a pandas dependency)?

Really strange, because the runs done less than an hour succeeded:
https://github.com/pandas-dev/pandas-stubs/actions/runs/7250869698/

Maybe something funky with Github?

@twoertwein
Copy link
Member

he runs done less than an hour succeeded

Happy to merge anyway :)

@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Dec 18, 2023

he runs done less than an hour succeeded

Happy to merge anyway :)

I reran the two failed jobs and they succeeded: https://github.com/pandas-dev/pandas-stubs/actions/runs/7251171162

@twoertwein twoertwein merged commit c0ca527 into pandas-dev:main Dec 18, 2023
@Dr-Irv Dr-Irv deleted the fix_nightly_1218 branch December 2, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants