Skip to content

Commit 7ed9f2a

Browse files
cfgongjreback
authored andcommitted
CLN: remove obsolete code in Categorical.fillna (#19880)
1 parent 6a2ece9 commit 7ed9f2a

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ dist
6161
.coverage
6262
coverage.xml
6363
coverage_html_report
64+
*.pytest_cache
6465

6566
# OS generated files #
6667
######################
@@ -90,7 +91,6 @@ scikits
9091

9192
# Unit / Performance Testing #
9293
##############################
93-
.pytest_cache/
9494
asv_bench/env/
9595
asv_bench/html/
9696
asv_bench/results/

pandas/core/arrays/categorical.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1627,14 +1627,6 @@ def fillna(self, value=None, method=None, limit=None):
16271627

16281628
values = self._codes
16291629

1630-
# Make sure that we also get NA in categories
1631-
if self.categories.dtype.kind in ['S', 'O', 'f']:
1632-
if np.nan in self.categories:
1633-
values = values.copy()
1634-
nan_pos = np.where(isna(self.categories))[0]
1635-
# we only have one NA in categories
1636-
values[values == nan_pos] = -1
1637-
16381630
# pad / bfill
16391631
if method is not None:
16401632

0 commit comments

Comments
 (0)