Skip to content

CLN: remove obsolete code in Categorical.fillna #19880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 15, 2018

Conversation

cfgong
Copy link
Contributor

@cfgong cfgong commented Feb 24, 2018

closes #19787

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
    Deleted code and tested block of code associated with NaN that should be unreachable.

@TomAugspurger
Copy link
Contributor

Thanks. Looks like some test cache files got in your commits.

Could you

  1. Delete those files: rm -rf .pytest_cache
  2. Remove them from the next commit (I think git rm .pytests_cache
  3. Add .pytest_cache to the .gitignore file at the root of the pandas directory?

And then push those changes.

@codecov
Copy link

codecov bot commented Feb 24, 2018

Codecov Report

Merging #19880 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19880      +/-   ##
==========================================
+ Coverage   91.78%   91.78%   +<.01%     
==========================================
  Files         152      152              
  Lines       49196    49191       -5     
==========================================
- Hits        45153    45151       -2     
+ Misses       4043     4040       -3
Flag Coverage Δ
#multiple 90.17% <ø> (ø) ⬆️
#single 41.82% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/categorical.py 95.47% <ø> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38afa93...a1df599. Read the comment docs.

@jreback jreback changed the title Issue #19787 CLN: remove obsolete code in Categorical.fillna Feb 24, 2018
@jreback jreback added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Categorical Categorical Data Type Clean labels Feb 24, 2018
@jreback jreback added this to the 0.23.0 milestone Mar 15, 2018
@jreback jreback merged commit 7ed9f2a into pandas-dev:master Mar 15, 2018
@jreback
Copy link
Contributor

jreback commented Mar 15, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Clean Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean: Categorical.fillna NaN in categories checking
3 participants