pytest deprecation warning

[TomAugspurger]

home/travis/miniconda3/envs/pandas/lib/python3.6/site-packages/_pytest/mark.py:73: RemovedInPytest4Warning: Applying marks directly to parameters is deprecated, please use pytest.param(..., marks=...) instead.
For more details, see: https://docs.pytest.org/en/latest/parametrize.html
  warnings.warn(MARK_PARAMETERSET_UNPACKING)

$ ag "pytest.mark.*\(.*\)\("
pandas/tests/test_base.py
1220:    pytest.mark.xfail(reason='PeriodArray not implemented')((

though there are probably others.

[bhaveshpoddar94]

Beginner Here. Can I look onto this?

[TomAugspurger]

It looks like https://github.com/pandas-dev/pandas/pull/17253/files fixed most of these.

pandas/pandas/tests/test_base.py

Line 1227 in a7a7f8c

pytest.mark.xfail(reason='PeriodArray not implemented')((

may be the only one left.

You should change that to use something like

    pytest.param(pd.PeriodIndex(['2017', '2018'], freq='D'),
                 np.array([17167, 17532]),
                 marks=pytest.mark.xfail(reason="Not implemented")),

instead.

[bhaveshpoddar94]

So I just replaced the code on line 1227 with
pytest.param(pd.PeriodIndex(['2017', '2018'], freq='D'), np.array([17167, 17532]), marks=pytest.mark.xfail(reason="Not implemented")),

Is that correct?

[TomAugspurger]

It seems like pytest temporarily un-deprecated the warning. Anyway, that seems about right. You can make a PR and we'll take a look.

…

On Sat, Mar 3, 2018 at 4:36 PM, Bhavesh Poddar ***@***.***> wrote: So I just replaced the code line on 1227 with pytest.param(pd.PeriodIndex(['2017', '2018'], freq='D'), np.array([17167, 17532]), marks=pytest.mark.xfail(reason="Not implemented")),` Is that correct? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19703 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIhkexutvuBm87Ypr46aE9zlS-UpKks5taxsKgaJpZM4SGCLb> .