Skip to content

Use isort for standardizing import formatting  #23048

Closed
@alimcmaster1

Description

@alimcmaster1

@TomAugspurger kindly pointed out on this PR that we could be using isort for formatting imports and have a standardized approach across the codebase.

I will draft up an initial config based on the rules used in dask-ml and the comments from @jbrockmendel in the above PR. If anyone feels strongly about any of the rules please comment here.

My proposed plan for introducing is we define a config and I run this for a handful of files. ( 1st PR )

We then over the period of a few weeks we encourage developers to run isort over their PRs and we can iron out any issues in the config set up.

Then we introduce a check into our CI build isort --recursive --check-only. And perhaps use this so developers can just run flake8 on their code like before.

Any thoughts/concerns here?

Metadata

Metadata

Assignees

No one assigned

    Labels

    CIContinuous IntegrationCleanCode StyleCode style, linting, code_checks

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions