Skip to content

Using OrderedDict in GroupBy Module(s) #25692

Closed
@WillAyd

Description

@WillAyd

Spurred by conversation in #25224 (comment) right now we are using plain old dictionaries in most of the groupby aggregation functions. For Py35 this makes the order of the returned result non-deterministic.

We could theoretically make a stronger assertion around the order here by replacing those dicts with OrderedDicts

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions