Closed
Description
This is from a PR recently rebased; I don't think the asv's were run when we merged the ordered deprecation changes
https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=13903
cc @jschendel
[ 4.36%] ··· categoricals.Rank.time_rank_string_cat failed
[ 4.36%] ···· Traceback (most recent call last):
File "/home/vsts/miniconda3/envs/pandas-dev/lib/python3.7/site-packages/asv/benchmark.py", line 1184, in main_run_server
main_run(run_args)
File "/home/vsts/miniconda3/envs/pandas-dev/lib/python3.7/site-packages/asv/benchmark.py", line 1052, in main_run
skip = benchmark.do_setup()
File "/home/vsts/miniconda3/envs/pandas-dev/lib/python3.7/site-packages/asv/benchmark.py", line 583, in do_setup
result = Benchmark.do_setup(self)
File "/home/vsts/miniconda3/envs/pandas-dev/lib/python3.7/site-packages/asv/benchmark.py", line 515, in do_setup
setup(*self._current_params)
File "/home/vsts/work/1/s/asv_bench/benchmarks/categoricals.py", line 138, in setup
ordered=True)
File "/home/vsts/work/1/s/pandas/core/generic.py", line 5600, in astype
**kwargs)
File "/home/vsts/work/1/s/pandas/core/internals/managers.py", line 529, in astype
return self.apply('astype', dtype=dtype, **kwargs)
File "/home/vsts/work/1/s/pandas/core/internals/managers.py", line 393, in apply
applied = getattr(b, f)(**kwargs)
File "/home/vsts/work/1/s/pandas/core/internals/blocks.py", line 514, in astype
**kwargs)
File "/home/vsts/work/1/s/pandas/core/internals/blocks.py", line 554, in _astype
deprecated_arg))
ValueError: Got an unexpected argument: ordered