PERF: asv's for non-int64 merges

[jreback]

in #28875 we enabled non-int64 merges between all integer types. I think we need asv's to see how performant these are: #28875 (comment)

[yogendrasoni]

pandas/asv_bench/benchmarks/join_merge.py already has a method time_on_int32.

def time_on_int32(self, direction):
merge_asof(self.df1d, self.df2d, on="time32", direction=direction)
Not sure if this covers. Let me know it anything is needed.

[jreback]

hmm was this asv just not working before?

can u show these asvs here (pls run them)

[jjlkant]

I think the main thing to note in regards to #28875 is that the change there only affected situations in regards to merge_asof when a tolerance value is set. Nothing changed on other merge cases.

None of the benchmarks currently defined here currently make use of this tolerance value, maybe that is something to add to the asv's?

pandas/asv_bench/benchmarks/join_merge.py

Lines 317 to 332 in 54b1151

	def time_on_int(self, direction):
	merge_asof(self.df1a, self.df2a, on="time", direction=direction)
	def time_on_int32(self, direction):
	merge_asof(self.df1d, self.df2d, on="time32", direction=direction)
	def time_by_object(self, direction):
	merge_asof(self.df1b, self.df2b, on="time", by="key", direction=direction)
	def time_by_int(self, direction):
	merge_asof(self.df1c, self.df2c, on="time", by="key2", direction=direction)
	def time_multiby(self, direction):
	merge_asof(
	self.df1e, self.df2e, on="time", by=["key", "key2"], direction=direction
	)

Would be willing to take this up on monday if nobody else wants to do it in the meantime

[jjlkant]

can u show these asvs here (pls run them)

The output of asv run -e -E existing -b ^join_merge.MergeAsof:

· Discovering benchmarks
· Running 5 total benchmarks (1 commits * 1 environments * 5 benchmarks)
[  0.00%] ·· Benchmarking existing-pyc__users_jjlkant_anaconda3_envs_pandas-dev_python.exe
[ 10.00%] ··· Running (join_merge.MergeAsof.time_by_int--)...
[ 40.00%] ··· Running (join_merge.MergeAsof.time_on_int--)..
[ 60.00%] ··· join_merge.MergeAsof.time_by_int                                                                                                                                          ok
[ 60.00%] ··· =========== ==========
               direction
              ----------- ----------
                backward   81.8±3ms
                forward    148±7ms
                nearest    214±4ms
              =========== ==========

[ 70.00%] ··· join_merge.MergeAsof.time_by_object                                                                                                                                       ok
[ 70.00%] ··· =========== ==========
               direction
              ----------- ----------
                backward   93.6±3ms
                forward    162±4ms
                nearest    217±5ms
              =========== ==========

[ 80.00%] ··· join_merge.MergeAsof.time_multiby                                                                                                                                         ok
[ 80.00%] ··· =========== ==========
               direction
              ----------- ----------
                backward   639±6ms
                forward    747±10ms
                nearest    834±30ms
              =========== ==========

[ 90.00%] ··· join_merge.MergeAsof.time_on_int                                                                                                                                          ok
[ 90.00%] ··· =========== ============
               direction
              ----------- ------------
                backward   27.6±0.5ms
                forward    30.5±0.6ms
                nearest    34.6±0.5ms
              =========== ============

[100.00%] ··· join_merge.MergeAsof.time_on_int32                                                                                                                                        ok
[100.00%] ··· =========== ============
               direction
              ----------- ------------
                backward   28.2±0.6ms
                forward    29.1±0.3ms
                nearest    34.7±0.9ms
              =========== ============

[jreback]

ok it think if can paramerize these asvs by tolerance would be great

[jjlkant]

Alright, I'll see what I can do!

Do you also want to include uint as a reference, for example uint64 and uint32?

[jreback]

sure could also add uint64