Closed
Description
It seems nice to have -Werror
in CI but as a conda-forge maintainer I quite often have to write patches to remove -Werror
from releases as the system distributions build packages on are not identical to the ones CI of upstream runs on. There is a large variety of compiler warnings and some may only show up when other C-defines are set. Also many new warning appear when you build with a newer compiler or different versions of the dependencies used.
My suggestion would be:
- Remove
-Werror
fromsetup.py
. - Add
-Werror
toCFLAGS
on CI to have the same result for pandas-dev as it is currently.
Original PR: #32163