Skip to content

Remove -Werror from setup.py #33315

Closed
@xhochy

Description

@xhochy

It seems nice to have -Werror in CI but as a conda-forge maintainer I quite often have to write patches to remove -Werror from releases as the system distributions build packages on are not identical to the ones CI of upstream runs on. There is a large variety of compiler warnings and some may only show up when other C-defines are set. Also many new warning appear when you build with a newer compiler or different versions of the dependencies used.

My suggestion would be:

  • Remove -Werror from setup.py.
  • Add -Werror to CFLAGS on CI to have the same result for pandas-dev as it is currently.

Original PR: #32163

Related issues: #33314, #33224

Metadata

Metadata

Assignees

No one assigned

    Labels

    BuildLibrary building on various platformsCIContinuous Integration

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions