CLN remove unnecessary trailing commas to get ready for new version of black

[MarcoGorelli]

The new version of black is consistent in how it handles the magic trailing commas. So if we upgrade black and apply it, lots of files will be changed. However, the diff needn't be so large if we remove unnecessary trailing commas before upgrading.

E.g. in pandas/core/aggregation.py there is

def reconstruct_func(
    func: Optional[AggFuncType], **kwargs,
) -> Tuple[
    bool, Optional[AggFuncType], Optional[List[str]], Optional[List[int]],
]:

which has an unnecessary trailing comma.

The new version of black would transform this as

def reconstruct_func(
    func: Optional[AggFuncType],
    **kwargs,
) -> Tuple[bool, Optional[AggFuncType], Optional[List[str]], Optional[List[int]],]:

However, if we instead remove the trailing comma and write it as

def reconstruct_func(
    func: Optional[AggFuncType], **kwargs
) -> Tuple[bool, Optional[AggFuncType], Optional[List[str]], Optional[List[int]]]:

then both the current and the new versions of black will be OK with it.

So, PRs to remove some unnecessary trailing commas would be welcome - perhaps keep each PR limited to 5-10 files changed.

Files that (may) need changing are:

• /asv_bench/benchmarks/arithmetic.py
• /pandas/core/array_algos/replace.py
• /doc/make.py
• /doc/source/conf.py
• /pandas/core/aggregation.py
• /pandas/core/algorithms.py
• /pandas/_vendored/typing_extensions.py
• /pandas/core/util/numba_.py
• /pandas/core/sorting.py
• /pandas/io/formats/latex.py
• /pandas/core/series.py
• /pandas/io/formats/format.py
• /pandas/core/frame.py
• /pandas/tests/arrays/sparse/test_array.py
• /pandas/tests/frame/test_analytics.py
• /pandas/tests/indexes/base_class/test_indexing.py
• /pandas/tests/indexes/test_common.py
• /pandas/tests/indexes/test_numeric.py
• /pandas/tests/io/test_gcs.py
• /pandas/tests/io/test_parquet.py
• /pandas/tests/scalar/timestamp/test_constructors.py
• /pandas/tests/series/test_operators.py
• /scripts/tests/test_validate_docstrings.py

EDIT

updated list of files which need changing

[MarcoGorelli]

See #35930, #35949, #35950 and for examples of how to open a PR for this.

No need to ask for permission to work on this, just choose a few files to work on and open a PR (optionally, you can comment here indicating that you're working on them)

[jorisvandenbossche]

I think the easiest way to find them is actually to let black (using the latest version) reformat the file(s), and then check in the diff for which ones the trailing comma can be removed (and then run black again)

[jpribyl]

I am looking at these right now

• pandas/core/internals/concat.py
• pandas/core/internals/managers.py
• pandas/core/internals/ops.py
• pandas/core/nanops.py
• pandas/core/ops/docstrings.py
• pandas/core/reshape/concat.py
• pandas/core/reshape/pivot.py
• pandas/core/reshape/reshape.py

edit: #35956

@MarcoGorelli if it looks good I can open another with some more later today.

[MarcoGorelli]

@jpribyl thanks! Yes, feel free to do so, any help here would be appreciated!

[jpribyl]

#35959

with several more files:

• pandas/core/series.py
• pandas/core/window/ewm.py
• pandas/core/window/indexers.py
• pandas/core/window/numba_.py
• pandas/core/window/rolling.py
• pandas/io/formats/css.py
• pandas/io/formats/format.py
• pandas/io/orc.py