Skip to content

CLN: handling of categorical with dropna=False in Grouping._codes_and_uniques #46909

Closed
@rhshadrach

Description

@rhshadrach

#46601 fixed using categorical with dropna=False in groupby by avoiding the categorical-specific logic in Grouping._codes_and_uniques. While this allowed for correct results, it seems better to fix the categorical-specific logic to handle dropna=False.

Avoiding the categorical-specific logic may also have some performance impact, I plan to benchmark it shortly.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions