Skip to content

Mark methods raising AbstractMethodError as abstractmethods? #48909

Open
@twoertwein

Description

@twoertwein

Many methods raise AbstractMethodError instead of being an abstractmethod. Based on #20363 and #19268 it seems that there might be a performance issue with inheriting from abc.ABC:

This class does not inherit from 'abc.ABCMeta' for performance reasons.

I didn't find a reference of why inheriting from abc.ABC is slow. Is that a python 2 thing? Would it make sense to use abc.ABC+abstractmethod instead of raising AbstractMethodError?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Error ReportingIncorrect or improved errors from pandasRefactorInternal refactoring of code

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions