Skip to content

STYLE enable ruff TCH #51740

@MarcoGorelli

Description

@MarcoGorelli

This code actually may make a difference to performance:

Task here is:
0. make sure you've followed the steps in https://pandas.pydata.org/docs/dev/development/contributing.html and have set up your development environment

  1. remove 3-5 of the lines in

pandas/pyproject.toml

Lines 293 to 326 in d385465

# TCH to be enabled gradually
"pandas/core/arrays/*" = ["TCH"]
"pandas/core/io/*" = ["TCH"]
"pandas/core/indexers/*" = ["TCH"]
"pandas/core/indexes/*" = ["TCH"]
"pandas/core/internals/*" = ["TCH"]
"pandas/core/groupby/*" = ["TCH"]
"pandas/core/methods/*" = ["TCH"]
"pandas/core/array_algos/*" = ["TCH"]
"pandas/core/dtypes/*" = ["TCH"]
"pandas/core/generic.py" = ["TCH"]
"pandas/core/frame.py" = ["TCH"]
"pandas/core/series.py" = ["TCH"]
"pandas/core/resample.py" = ["TCH"]
"pandas/core/nanops.py" = ["TCH"]
"pandas/core/apply.py" = ["TCH"]
"pandas/core/base.py" = ["TCH"]
"pandas/core/algorithms.py" = ["TCH"]
"pandas/core/ops/*" = ["TCH"]
"pandas/core/sorting.py" = ["TCH"]
"pandas/core/construction.py" = ["TCH"]
"pandas/core/common.py" = ["TCH"]
"pandas/core/missing.py" = ["TCH"]
"pandas/core/util/*" = ["TCH"]
"pandas/core/reshape/*" = ["TCH"]
"pandas/core/strings/*" = ["TCH"]
"pandas/core/tools/*" = ["TCH"]
"pandas/core/window/*" = ["TCH"]
"pandas/io/*" = ["TCH"]
"pandas/tseries/*" = ["TCH"]
"pandas/tests/*" = ["TCH"]
"pandas/plotting/*" = ["TCH"]
"pandas/util/*" = ["TCH"]
"pandas/_libs/*" = ["TCH"]

  1. run pre-commit run ruff --all-files, and fix up the issues it reports. You can see STYLE start enabling TCH #51687 for some examples of how to do this
  2. if pre-commit run ruff --all-files passes, then stage, commit, push, open pull request, celebrate

Please don't comment "take" on this issue (as multiple people can be assigned), and don't ask for permission to work on it. Instead, just leave a comment letting people know which

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions