BUG: construct Timestamp with year out of pydatetime range #52191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Mar 27, 2023
| f"Cannot construct a Timestamp with year={year} and " | ||
| "non-zero nanoseconds" | ||
| ) | ||
| return obj.as_unit("us").replace(year=year) |
There was a problem hiding this comment.
What if the year goes beyond the us max year but within the ms max year?
There was a problem hiding this comment.
Good point. And same for seconds.
Now you've got me thinking about value-dependent behavior. We should probably get "us" unit whenever nanos is zero-or-None regardless of year. Same for getting "ms" if micros is (zero % 1000)-or-None, etc
mroeschke
added
Non-Nano
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Closing to clear the queue, but feel free to reopen if you want to continue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.