DOC:

[idealcrouch]

Pandas version checks

• I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

https://pandas.pydata.org/docs/user_guide/io.html#io-read-html

Documentation problem

This script in the documentation returns an error since the source material changed on Wikipedia.

import pandas pd
url_mcc = "https://en.wikipedia.org/wiki/Mobile_country_code"
dfs = pd.read_html(
    url_mcc,
    match="Telekom Albania",
    header=0,
    converters={"MNC": str},
)

returns the error
ValueError: No tables found matching pattern 'Telekom Albania'

Suggested fix for documentation

I believe the fix is to simply match on a different table name (not Telekom Albania). Even using "Albania" works for me.

import pandas as pd
url_mcc = "https://en.wikipedia.org/wiki/Mobile_country_code"
dfs = pd.read_html(
    url_mcc,
    match="Albania",
    header=0,
    converters={"MNC": str},
)

[DavidToneian]

Hi idealcrouch,

thanks for reporting this!

Your fix would indeed work, but the example may break again if the contents of the page would change in certain ways, e.g., Albania changed their name.

How about fixing the referenced version of the page instead to a known-working state, e.g. https://en.wikipedia.org/wiki/Mobile_country_code?oldid=899173761?

Would you like to open a PR for this?

[thiagogquinto]

Hey @DavidToneian, could I make the PR, if I am correct, this is the location of the file, so could I make your suggested change and make a PR or do you prefer to wait for the @idealcrouch's response?

[DavidToneian]

As far as I'm concerned, feel free to create the PR, @thiagogquinto! The location you identified is correct.

[idealcrouch]

Hi everyone, apologies for the late reply. I'm totally happy to make the change this afternoon if that's helpful. I haven't done a pull request in pandas before, so I would just request a bit of time to make sure I'm doing it right. I see the background instructions here: https://pandas.pydata.org/docs/dev/development/contributing.html Is there anything else I should check out before trying it? Thiago, if you prefer to get it done quickly, then definitely feel free. Please just let me know if I should try it later. Thanks a lot, John

…

On Tue, Aug 29, 2023 at 4:54 AM David Toneian ***@***.***> wrote: As far as I'm concerned, feel free to create the PR, @thiagogquinto <https://github.com/thiagogquinto>! The location you identified is correct. — Reply to this email directly, view it on GitHub <#54822 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEMUBZJ45LS4QMTJY3RWOBLXXWU3LANCNFSM6AAAAAA4BYWYPQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[thiagogquinto]

Thanks @idealcrouch, but you can make it, It's your issue.

[idealcrouch]

Cool. I'll tackle it this afternoon. Thanks everyone.

…

On Tue, Aug 29, 2023 at 7:49 AM Thiago Gariani ***@***.***> wrote: Thanks @idealcrouch <https://github.com/idealcrouch>, but you can make it, It's your issue. — Reply to this email directly, view it on GitHub <#54822 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEMUBZM3QM4TL7U5QYEHWO3XXXJMVANCNFSM6AAAAAA4BYWYPQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>