Skip to content

Give all NotImplementedErrors a description #7872

Closed
@hayd

Description

@hayd

Currently some NotImplementedErrors don't have a description (most do!) .

raise NotImplemented
# should be
raise NotImplemented("short description of thing which isn't implemented")

I think this would be pretty useful, and makes it less confusing for users, and at least they would be pointed in the right direction to request said feature (and know which bit of specifically is NotImplemented)...

You can find them all with grep (probably more usefully the same regex in your text editor):

grep "NotImplementedError$" pandas/**/*.py -r -n

Metadata

Metadata

Assignees

No one assigned

    Labels

    Code StyleCode style, linting, code_checksDocsError ReportingIncorrect or improved errors from pandas

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions