BUG: concat on axis=0 with categorical (GH10177) #10179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2929,6 +2929,23 @@ def test_pickle_v0_15_2(self): | |||
| # | |||
| self.assert_categorical_equal(cat, pd.read_pickle(pickle_path)) | |||
|
|
|||
| def test_concat_categorical(self): | |||
| df1 = pd.DataFrame(np.arange(18).reshape(6, 3), columns=["a", "b", "c"]) | |||
There was a problem hiding this comment.
add the issue number as a comment here
|
@jreback: I implemented your suggested changes and it seems that it doesn't break anything else, at least according to the unit tests. |
|
I rebased the changes against latest master. The Travis CI error is due to a timeout when creating the build environment, not sure how I can resolve it. |
|
pls rebase and squash. |
| @@ -78,3 +78,5 @@ Bug Fixes | |||
| - Bug in ``ExcelReader`` when worksheet is empty (:issue:`6403`) | |||
| - Bug in ``Table.select_column`` where name is not preserved (:issue:`10392`) | |||
| - Bug in ``DataFrame.interpolate`` with ``axis=1`` and ``inplace=True`` (:issue:`10395`) | |||
| - Bug in `pandas.concat` with ``axis=0`` when column is of dtype category (:issue:`10177`) | |||
There was a problem hiding this comment.
use double back ticks around category
|
@jreback: I updated my merge request based on your feedback. |
jreback
added a commit
that referenced
this pull request
Jun 27, 2015
BUG: concat on axis=0 with categorical (GH10177)
|
@sebp thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains a proposed fix for #10177