BUG: Index name lost in conv #10875 #10945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
| @@ -282,11 +283,15 @@ def _convert_listlike(arg, box, format): | |||
| if isinstance(arg, (list,tuple)): | |||
| arg = np.array(arg, dtype='O') | |||
|
|
|||
| name = None | |||
| if isinstance(arg, ABCIndexClass): | |||
There was a problem hiding this comment.
I would put this in the top-level if-else (e.g. where Series) is (same for timedelta)
in to_datetime, to_timedelta
chris-b1
force-pushed
the
timeseries-index-name
branch
from
dfc9ad7 to
03f6f40
Compare
|
@jreback moved where you noted |
jreback
added a commit
that referenced
this pull request
Aug 31, 2015
BUG: Index name lost in conv #10875
|
@chris-b1 thank you sir! your contributions have been awesome! keep em coming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10875, when
Indexis converted viato_datetime,to_timedeltapart of #9862 master issue