Skip to content

COMPAT/PERF: lib.ismember_int64 on older numpies/cython not comparing correctly #11232 #11252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2015

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Oct 6, 2015

closes #11232

PERF: use np.in1d on larger isin sizes

@jreback jreback added Testing pandas testing functions or related to the test suite Performance Memory or execution speed performance Compat pandas objects compatability with Numpy or Python functions labels Oct 6, 2015
@jreback jreback added this to the 0.17.0 milestone Oct 6, 2015
@jreback jreback force-pushed the isin branch 5 times, most recently from a5ffc3f to aa4a8c5 Compare October 6, 2015 12:59
… correctly

PERF: use np.in1d on larger isin sizes
jreback added a commit that referenced this pull request Oct 6, 2015
COMPAT/PERF: lib.ismember_int64 on older numpies/cython not comparing correctly #11232
@jreback jreback merged commit c13dc7d into pandas-dev:master Oct 6, 2015
@kuraga
Copy link

kuraga commented Jan 22, 2018

...and series.isin(list_of_strings) throws an error since len(series) > 1000000...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions Performance Memory or execution speed performance Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tseries and TestSeries test errors on Python 3.3 and OSX
2 participants