ENH: add error message for merge with Series GH12081 #12112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Reshaping
| @@ -261,6 +261,20 @@ def test_join_on_fails_with_different_column_counts(self): | |||
| index=tm.makeCustomIndex(10, 2)) | |||
| merge(df, df2, right_on='a', left_on=['a', 'b']) | |||
|
|
|||
| def test_join_on_fails_with_left_series(self): | |||
| with tm.assertRaisesRegexp(ValueError, 'Series'): | |||
| series = Series([0, 1, 2]) | |||
There was a problem hiding this comment.
iterate thru a bunch of things (e.g. ndarray, number, string) and assert that they raise as well
dan-tee
force-pushed
the
merge-with-series
branch
from
e609393 to
dcff8ca
Compare
|
@jreback incorporated your comments |
| @@ -261,6 +261,52 @@ def test_join_on_fails_with_different_column_counts(self): | |||
| index=tm.makeCustomIndex(10, 2)) | |||
| merge(df, df2, right_on='a', left_on=['a', 'b']) | |||
|
|
|||
|
|
|||
| def test_join_on_fails_with_left_series(self): | |||
| # GH12081 | |||
There was a problem hiding this comment.
you can put all of these test cases in a single test with a loop
dan-tee
force-pushed
the
merge-with-series
branch
from
5f06cd1 to
74bb643
Compare
|
@jreback true, looks much nicer now. |
|
looks good. can you add a whatsnew note in API changes. |
dan-tee
force-pushed
the
merge-with-series
branch
from
74bb643 to
40ced26
Compare
|
@jreback I added the note to whatsnew. I didn't manage to run Sphinx to test build the doc though. Can you give it a spin? I'll have to clean my development environment and move from using pip to conda. Just don't really have the time now. |
|
@dan-tee no looks good. thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12081