-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Update truncate() documentation and testcases #13024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1560,6 +1560,17 @@ def test_truncate_fillna_bug(self): | |||
# it works! | |||
result.fillna(value=0.0) | |||
|
|||
def test_truncate_outofbounds(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's move the .truncate
tests to test_generic
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and use the generic features to test Series/DataFrame/Panel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you said done, but it doesn't appear to be pushed. you need to use _construct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest (force) push uses assert_series_equal
below. Were you pointing out something different you would like to see?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to structure the test so its runnable in all of the sub-classses Testers so its tested on Series/DataFrame
etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got you. I ran into issues (memory, indeces) when trying to generalize, so decided to move it under Series (only).
I'm not sure what to make of those codecov failures ... |
just do the big selection across the 0th dimension |
The actual tests were OK (although I seen OutOfMemory exceptions ...), but the For How do you merge these? |
Are you OK with this being under |
you need to make this generic, so no |
@jreback Please offer some snippets on how you see this being make generic (I described what I ran into in the previous post). Thanks |
@jreback How do you see this moving forward? Thanks |
so in
so will give you the first dim of 1e6 and the others 1 |
@jreback Thank you. I made the changes, the 2e6 takes a long time to run locally (in Panel) ... |
Timing out in travis-ci too |
thanks @gliptak the panel comparator was doing things a very slow way. all fixed up. |
@jreback Thank you for fixing Panel comparator. |
git diff upstream/master | flake8 --diff