Skip to content

TST: assert_dict_equal to check input type #13264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

TST: assert_dict_equal to check input type #13264

wants to merge 1 commit into from

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented May 23, 2016

  • tests added / passed
  • passes git diff upstream/master | flake8 --diff

assert_dict_equal now checks input is dict instance. Fixed some tests which passes Series to it.

@sinhrks sinhrks added the Testing pandas testing functions or related to the test suite label May 23, 2016
@sinhrks sinhrks added this to the 0.18.2 milestone May 23, 2016
@jreback
Copy link
Contributor

jreback commented May 23, 2016

lgtm, merge on pass.

@jreback jreback closed this in 8662cb9 May 24, 2016
@jreback
Copy link
Contributor

jreback commented May 24, 2016

thanks @sinhrks

I added a couple of unrelated fixes to correct some numpy warnings.

@sinhrks sinhrks deleted the test_dict branch May 24, 2016 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sinhrks @jreback