Skip to content

Remove imp and just use importlib to avoid memory error when importin… #13284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove imp and just use importlib to avoid memory error when importin… #13284

wants to merge 2 commits into from

Conversation

nparley
Copy link
Contributor

@nparley nparley commented May 25, 2016 •
edited by jreback
Loading

Remove imp from pandas.show_versions() to fix memory problem.

@jreback
Copy link
Contributor

jreback commented May 25, 2016

hmm, importlib is only available in PY3 I think.

can you hack something from this:
https://pypi.python.org/pypi/importlib (don't want to add as a dep)

@jreback jreback added the Build Library building on various platforms label May 25, 2016
@jreback jreback added this to the 0.18.2 milestone May 25, 2016
@nparley
Copy link
Contributor Author

nparley commented May 25, 2016 •
edited
Loading

importlib is in 2.7, does pandas still support 2.6?

@jreback
Copy link
Contributor

jreback commented May 25, 2016

oh, then that's ok

jreback
jreback reviewed May 25, 2016
View reviewed changes
pandas/util/print_versions.py
except (ImportError):
import importlib
mod = importlib.import_module(modname)
import importlib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was wondering does this be here or can be a top-level import?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it should be a top-level import now you are right.

@jreback
Copy link
Contributor

jreback commented May 25, 2016

ok this looks good. ping when green.

@jreback jreback closed this in b4e2d34 May 25, 2016
@jreback
Copy link
Contributor

jreback commented May 25, 2016

thanks @nparley

@nparley nparley deleted the imp branch May 26, 2016 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.

pandas.show_versions causing malloc_error_break
2 participants
@nparley @jreback