Skip to content

CLN: Replace float64_t with int64_t in _ensure_components #13673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2016

Conversation

yui-knk
Copy link
Contributor

@yui-knk yui-knk commented Jul 16, 2016

  • passes git diff upstream/master | flake8 --diff

@jreback
Copy link
Contributor

jreback commented Jul 16, 2016

I would be surprised if this works
the issue is overflow on non 64bit platforms

@codecov-io
Copy link

codecov-io commented Jul 16, 2016

Current coverage is 84.38%

Merging #13673 into master will increase coverage by <.01%

@@             master     #13673   diff @@
==========================================
  Files           142        142          
  Lines         51223      51223          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43223      43224     +1   
+ Misses         8000       7999     -1   
  Partials          0          0          

Powered by Codecov. Last updated by d7c028d...6854086

@yui-knk
Copy link
Contributor Author

yui-knk commented Jul 16, 2016

I feel all number (_d, _h, or etc.) is smaller than ivalue(int64_t), so if problem happens on non 64bit platforms, float64_t does not solve problems.

@sinhrks sinhrks added Timedelta Timedelta data type Clean labels Jul 16, 2016
@jreback jreback added this to the 0.19.0 milestone Jul 20, 2016
@jreback jreback merged commit aa3ece3 into pandas-dev:master Jul 20, 2016
@jreback
Copy link
Contributor

jreback commented Jul 20, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants