Skip to content

BUG: RangeIndex accepting length-1 arrays as argument #13765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Jul 23, 2016

@jorisvandenbossche jorisvandenbossche added Bug Indexing Related to indexing on series/frames, not to indexes themselves Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jul 23, 2016
@jorisvandenbossche jorisvandenbossche added this to the 0.19.0 milestone Jul 23, 2016
@jorisvandenbossche jorisvandenbossche force-pushed the bug-13542-concat-multiindex branch from 48506ca to 440d262 Compare July 23, 2016 16:38
@codecov-io
Copy link

codecov-io commented Jul 23, 2016

Current coverage is 85.27% (diff: 100%)

Merging #13765 into master will decrease coverage by <.01%

@@             master     #13765   diff @@
==========================================
  Files           139        139          
  Lines         50211      50214     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42819      42820     +1   
- Misses         7392       7394     +2   
  Partials          0          0          

Powered by Codecov. Last update 5f49638...6180487

@jorisvandenbossche jorisvandenbossche force-pushed the bug-13542-concat-multiindex branch from 440d262 to 6180487 Compare August 15, 2016 14:47
@jorisvandenbossche
Copy link
Member Author

@jreback OK?

@jreback
Copy link
Contributor

jreback commented Aug 15, 2016

can you add the orginal issue example somewhere (and assert it works)

@jorisvandenbossche
Copy link
Member Author

That's what I added in test_concat.py (next to the addition in the tests in test_range.py) I think?

@jreback
Copy link
Contributor

jreback commented Aug 15, 2016

is it a simplified example?

the original one is on a panel

@jorisvandenbossche
Copy link
Member Author

Well, looking back at the original issue #13542, this is indeed not the original example I included in the tests. But I found the reported example rather convoluted/difficult to comprehend what was going on. And the example I added, is a simplified (whithout using panels) example that experience exactly the same issue (it is what happened inside the groupby).

But I can add the original panel example as well if you like

@jreback
Copy link
Contributor

jreback commented Aug 15, 2016

it's fine
a simplified example is often better anyhow
so lgtm

@jorisvandenbossche jorisvandenbossche merged commit 66f9591 into pandas-dev:master Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: groupby.transform fails with incompatible size
3 participants