ENH: Improve error message for repeated Stata categories #13949
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -397,6 +397,7 @@ Other enhancements | |||
| - ``Series.append`` now supports the ``ignore_index`` option (:issue:`13677`) | |||
| - ``.to_stata()`` and ``StataWriter`` can now write variable labels to Stata dta files using a dictionary to make column names to labels (:issue:`13535`, :issue:`13536`) | |||
| - ``.to_stata()`` and ``StataWriter`` will automatically convert ``datetime64[ns]`` columns to Stata format ``%tc``, rather than raising a ``ValueError`` (:issue:`12259`) | |||
| - ``read_stata()`` and ``StataReader`` return more explicit error message is given when reading Stata data files containing value labels are repeated when ``convert_categoricals=True`` (:issue:`13923`) | |||
There was a problem hiding this comment.
"raise with a more explicit error message when reading Stata files with repeated value labels when convert_categoricals=True".
bashtage
force-pushed
the
categorical-error-message
branch
from
aee7b63 to
72cc94c
Compare
Current coverage is 85.29% (diff: 100%)@@ master #13949 diff @@
==========================================
Files 139 139
Lines 50159 50169 +10
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 42786 42792 +6
- Misses 7373 7377 +4
Partials 0 0
|
jreback
added
Error Reporting
| @@ -1649,6 +1649,13 @@ def _do_convert_categoricals(self, data, value_label_dict, lbllist, | |||
| categories.append(value_label_dict[label][category]) | |||
| else: | |||
| categories.append(category) # Partially labeled | |||
| if len(categories) != len(set(categories)): | |||
There was a problem hiding this comment.
I think its a bit more python to:
try:
cat_data.categories = categories
except ValueError:
# show your new ValueError
as non-unique category setting already raises.
bashtage
force-pushed
the
categorical-error-message
branch
from
72cc94c to
533a9a0
Compare
Improve the error message to be more explicit when attempting to read Stata files containing repeated categories. closes pandas-dev#13923
bashtage
force-pushed
the
categorical-error-message
branch
from
533a9a0 to
0880d02
Compare
|
thanks! great as usual! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffImprove the error message to be more explicit when attempting to read Stata
files containing repeated categories.
closes #13923