BUG: Fix Empty DataFrame.style.render raises IndexError #15971
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix attempt for Issue pandas-dev#15953 Handles DataFrames and Series with no rows or columns using `pd.DataFrame().empty` or `pd.Series().empty`
TomAugspurger
requested changes
Apr 10, 2017
| @@ -218,8 +218,8 @@ def format_attr(pair): | |||
|
|
|||
| cell_context = dict() | |||
|
|
|||
| n_rlvls = self.data.index.nlevels | |||
| n_clvls = self.data.columns.nlevels | |||
| n_rlvls = 0 if self.data.empty else self.data.index.nlevels | |||
There was a problem hiding this comment.
I think you'll have to change this around a bit. DataFrame.empty is True if either the index or columns is empty. So you get
pd.DataFrame([], index=[1, 2]).empty # True
pd.DataFrame([], columns=['A', 'B']).empty # True
|
I think our desired output is the same as the notebook
|
Codecov Report
@@ Coverage Diff @@
## master #15971 +/- ##
==========================================
+ Coverage 91% 91.01% +<.01%
==========================================
Files 145 145
Lines 49581 49581
==========================================
+ Hits 45122 45124 +2
+ Misses 4459 4457 -2
Continue to review full report at Codecov.
|
|
pls rebase / update according to the comments. Needs a tests. |
|
whatsnew notes should go in |
|
Looks like #16441 fixed this in the meantime. Thanks anyways @sandipchatterjee, sorry about the duplicated effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix attempt for Issue #15953
Handles DataFrames and Series with no rows or columns
using
pd.DataFrame().emptyorpd.Series().emptygit diff upstream/master --name-only -- '*.py' | flake8 --diff