Skip to content

ENH: Crosstab support for setting the margins name #15972 #15973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ENH: Crosstab support for setting the margins name #15972 #15973

wants to merge 1 commit into from

Conversation

slide333333
Copy link

closes #15972

TomAugspurger
TomAugspurger reviewed Apr 11, 2017
View reviewed changes
pandas/tools/pivot.py
@@ -420,6 +421,9 @@ def crosstab(index, columns, values=None, rownames=None, colnames=None,
- If margins is `True`, will also normalize margin values.

.. versionadded:: 0.18.1
margins_name : string, default 'All'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a ..versionadded:: 0.20.0 for this parameter?

TomAugspurger
TomAugspurger requested changes Apr 11, 2017
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

One comment on the docstring.

Can you also add a note in the whatsnew file, and a couple tests (one with the default, one with a user-specified argument).

@TomAugspurger TomAugspurger added API Design Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Apr 11, 2017
@TomAugspurger TomAugspurger added this to the 0.20.0 milestone Apr 11, 2017
@codecov
Copy link

codecov bot commented Apr 11, 2017

Codecov Report

Merging #15973 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15973      +/-   ##
==========================================
+ Coverage      91%   91.01%   +<.01%     
==========================================
  Files         145      145              
  Lines       49581    49581              
==========================================
+ Hits        45123    45124       +1     
+ Misses       4458     4457       -1
Flag Coverage Δ
#multiple 88.77% <ø> (ø) ⬆️
#single 40.57% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/tools/pivot.py 95.07% <ø> (ø) ⬆️
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbbcc10...f976fdd. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 11, 2017 •
edited
Loading

Codecov Report

Merging #15973 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15973      +/-   ##
==========================================
+ Coverage      91%   91.01%   +<.01%     
==========================================
  Files         145      145              
  Lines       49581    49581              
==========================================
+ Hits        45123    45124       +1     
+ Misses       4458     4457       -1
Flag Coverage Δ
#multiple 88.77% <ø> (ø) ⬆️
#single 40.57% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/tools/pivot.py 95.07% <ø> (ø) ⬆️
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbbcc10...f976fdd. Read the comment docs.

@jreback jreback removed this from the 0.20.0 milestone Apr 12, 2017
@jreback
Copy link
Contributor

jreback commented May 7, 2017

needs a rebase and tests

@TomAugspurger TomAugspurger added this to the 0.20.2 milestone May 8, 2017
@TomAugspurger
Copy link
Contributor

Looks like #16489 fixed this in the meantime. Sorry @slide333333 , but thanks anyways for the PR.

@TomAugspurger TomAugspurger modified the milestones: No action, 0.20.2 May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger requested changes

Assignees
No one assigned
Labels
API Design Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crosstab support for setting the margins name
3 participants
@slide333333 @jreback @TomAugspurger