-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC/API: Move Styler import #16059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC/API: Move Styler import #16059
Conversation
From the top-level to pandas.io.formats.style.Styler, which is a bit wordy but I was having circular-import issues at pandas.io.formats. I think that's ok since people won't really be using this interactively. Closes pandas-dev#16009
api.rst also needs an update |
In this issue (#16009), I also raised the question whether we should deprecate the old location. But is there currently a reason that a user would use the actual object instead of access it through |
Codecov Report
@@ Coverage Diff @@
## master #16059 +/- ##
==========================================
+ Coverage 90.79% 90.82% +0.02%
==========================================
Files 156 155 -1
Lines 50534 50518 -16
==========================================
- Hits 45883 45881 -2
+ Misses 4651 4637 -14
Continue to review full report at Codecov.
|
I believe api.rst was already changed as part of the move.
For the deprecation... I could go either way. 5516aa4 adds a compatibility shim pointing to the new location. I'll add it to the master list if we decide to include it. |
Codecov Report
@@ Coverage Diff @@
## master #16059 +/- ##
==========================================
+ Coverage 90.79% 90.81% +0.02%
==========================================
Files 156 156
Lines 50534 50521 -13
==========================================
Hits 45883 45883
+ Misses 4651 4638 -13
Continue to review full report at Codecov.
|
Ah yes, my bad! (I actually even said it myself #16009 (comment) :-)) |
@jorisvandenbossche all good for you? Is everyone OK with a deprecation warning from |
* DOC/API: Move Styler import From the top-level to pandas.io.formats.style.Styler, which is a bit wordy but I was having circular-import issues at pandas.io.formats. I think that's ok since people won't really be using this interactively. Closes pandas-dev#16009 * Added deprecation warning and shim
From the top-level to pandas.io.formats.style.Styler, which is a bit wordy
but I was having circular-import issues at pandas.io.formats.
I think that's ok since people won't really be using this interactively.
Closes #16009