TYPO: IntervalIndex.symmetric_differnce -> IntervalIndex.symmetric_difference #18476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18476 +/- ##
==========================================
+ Coverage 91.3% 91.31% +0.01%
==========================================
Files 163 163
Lines 49781 49781
==========================================
+ Hits 45451 45456 +5
+ Misses 4330 4325 -5
Continue to review full report at Codecov.
|
jreback
requested changes
Nov 25, 2017
doc/source/whatsnew/v0.21.1.txt
Outdated
| @@ -73,7 +73,7 @@ Indexing | |||
| - Bug in a boolean comparison of a ``datetime.datetime`` and a ``datetime64[ns]`` dtype Series (:issue:`17965`) | |||
| - Bug where a ``MultiIndex`` with more than a million records was not raising ``AttributeError`` when trying to access a missing attribute (:issue:`18165`) | |||
| - Bug in :class:`IntervalIndex` constructor when a list of intervals is passed with non-default ``closed`` (:issue:`18334`) | |||
| - | |||
| - Bug in ``IntervalIndex.symmetric_difference()`` where the symmetric difference with a non-``IntervalIndex`` did not raise (:issue:`18475`) | |||
There was a problem hiding this comment.
move this to 0.22. I am not sure we can backport the actual test changes w/o causing some hassle.
Alternatively you can split this to 2 pr's, 1 the test changes and 1 the perf fix (which we can backport).
jschendel
force-pushed
the
iv-idx-sym-diff
branch
from
3d18dd6 to
ab4eeb9
Compare
jschendel
force-pushed
the
iv-idx-sym-diff
branch
from
ab4eeb9 to
9f6411b
Compare
jreback
approved these changes
Nov 26, 2017
|
thanks @jschendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffBefore this,
IntervalIndex.symmetric_differencehit the base class implementation, and appeared to generally be working, albeit without full error handling and with worse performance than the intended implementation.Also went through and did some more work on the tests:
test_set_operation_errors, since this didn't have full coverage of all set ops prior.self.create_indexprevious only created an index with two elements, which seemed kind of small; increased this to 10 elements, and updated impacted tests accordingly.name, and updated a few tests to use this.