Skip to content

DOC: replaced 'Good as first PR' with 'good first issue' #18806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2017

Conversation

raybellwaves
Copy link
Contributor

@raybellwaves raybellwaves commented Dec 16, 2017

  • [NA] closes #xxxx
  • [NA] tests added / passed
  • [NA] passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • [NA] whatsnew entry

Was browsing https://github.com/pandas-dev/pandas/tree/master/doc and it seemed the 'Good as first PR' had no open issues, whereas 'good first issue' has quite a few open issues.
I'm guessing the 'Good as first PR' label was not well used/got renamed to 'good first issue' label?

@codecov
Copy link

codecov bot commented Dec 16, 2017

Codecov Report

Merging #18806 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18806      +/-   ##
==========================================
- Coverage   91.64%    91.6%   -0.05%     
==========================================
  Files         154      154              
  Lines       51430    51430              
==========================================
- Hits        47131    47110      -21     
- Misses       4299     4320      +21
Flag Coverage Δ
#multiple 89.46% <ø> (-0.03%) ⬇️
#single 40.83% <ø> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 64.78% <0%> (-1.74%) ⬇️
pandas/core/frame.py 97.68% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f1e71...0779857. Read the comment docs.

@gfyoung gfyoung added the Docs label Dec 17, 2017
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jreback jreback added this to the 0.22.0 milestone Dec 18, 2017
@jreback jreback merged commit 8e0e354 into pandas-dev:master Dec 18, 2017
@jreback
Copy link
Contributor

jreback commented Dec 18, 2017

thanks @raybellwaves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants