BUG: raise error for groupby() with invalid tuple key #18826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Bug
Groupby
Regression
jschendel
reviewed
Dec 18, 2017
pandas/core/groupby.py
Outdated
| @@ -2978,7 +2978,8 @@ def is_in_obj(gpr): | |||
|
|
|||
| def _is_label_like(val): | |||
| return (isinstance(val, compat.string_types) or | |||
| (val is not None and is_scalar(val))) | |||
| (val is not None and is_scalar(val)) or | |||
| isinstance(val, tuple)) | |||
There was a problem hiding this comment.
Could the second isinstance just be combined with the first, i.e. isinstance(val, (compat.string_types, tuple))?
There was a problem hiding this comment.
Cool, I had no idea of the support for nested tuples (which is undocumented, but apparently well recognized ). So OK.
Codecov Report
@@ Coverage Diff @@
## master #18826 +/- ##
==========================================
- Coverage 91.64% 91.62% -0.02%
==========================================
Files 154 154
Lines 51408 51408
==========================================
- Hits 47113 47104 -9
- Misses 4295 4304 +9
Continue to review full report at Codecov.
|
toobaz
force-pushed
the
groupby_missing_tuple_18798
branch
from
9a34ad1 to
5fc5240
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff