Skip to content

Fixed read_json int overflow #18905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2017
Merged

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Dec 22, 2017

@WillAyd
Copy link
Member Author

WillAyd commented Dec 22, 2017

FWIW there are other instances of casting to int64 in the json module which should probably be catching an OverflowError as well, but I did not update them because they were unrelated to the issue brought up. Plan to look at those in more detail for a separate change to determine usage

@codecov
Copy link

codecov bot commented Dec 22, 2017

Codecov Report

Merging #18905 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18905      +/-   ##
==========================================
+ Coverage   91.62%   91.62%   +<.01%     
==========================================
  Files         150      150              
  Lines       48939    48939              
==========================================
+ Hits        44838    44840       +2     
+ Misses       4101     4099       -2
Flag Coverage Δ
#multiple 89.98% <100%> (ø) ⬆️
#single 41.14% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/json/json.py 92.56% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9cc821...cf9f513. Read the comment docs.

@gfyoung gfyoung added Dtype Conversions Unexpected or buggy dtype conversions IO JSON read_json, to_json, json_normalize Regression Functionality that used to work in a prior pandas version labels Dec 22, 2017
@jreback
Copy link
Contributor

jreback commented Dec 23, 2017

looks good. can you add a whatsnew note. ping on green.

happy to have you open / PR other issues you see.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as indicated

@WillAyd
Copy link
Member Author

WillAyd commented Dec 23, 2017

No problem. Do you want this in 0.22 or 0.23?

@jreback
Copy link
Contributor

jreback commented Dec 23, 2017

everything for 0.23.0

@jreback
Copy link
Contributor

jreback commented Dec 23, 2017

0.22.0 is a special release with only a single breaking change.

@WillAyd
Copy link
Member Author

WillAyd commented Dec 24, 2017

@jreback all green

@jreback jreback added this to the 0.23.0 milestone Dec 27, 2017
@jreback jreback merged commit ee2e6de into pandas-dev:master Dec 27, 2017
@jreback
Copy link
Contributor

jreback commented Dec 27, 2017

thanks @WillAyd

keep em coming!

hexgnu pushed a commit to hexgnu/pandas that referenced this pull request Dec 28, 2017
@WillAyd WillAyd deleted the json-overflow branch February 27, 2018 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions IO JSON read_json, to_json, json_normalize Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OverflowError for string of large numbers (int64) while reading json
3 participants