-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Fixed read_json int overflow #18905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed read_json int overflow #18905
Conversation
FWIW there are other instances of casting to |
Codecov Report
@@ Coverage Diff @@
## master #18905 +/- ##
==========================================
+ Coverage 91.62% 91.62% +<.01%
==========================================
Files 150 150
Lines 48939 48939
==========================================
+ Hits 44838 44840 +2
+ Misses 4101 4099 -2
Continue to review full report at Codecov.
|
looks good. can you add a whatsnew note. ping on green. happy to have you open / PR other issues you see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as indicated
No problem. Do you want this in 0.22 or 0.23? |
everything for 0.23.0 |
0.22.0 is a special release with only a single breaking change. |
e6ea0e8
to
cf9f513
Compare
@jreback all green |
thanks @WillAyd keep em coming! |
git diff upstream/master -u -- "*.py" | flake8 --diff