Fix bugs in FY5253Quarter and LastWeekOfMonth #19036
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19036 +/- ##
==========================================
+ Coverage 91.51% 91.54% +0.02%
==========================================
Files 148 148
Lines 48807 48808 +1
==========================================
+ Hits 44667 44680 +13
+ Misses 4140 4128 -12
Continue to review full report at Codecov.
|
|
|
||
|
|
||
| def test_fy5253qtr_onoffset_nearest(): | ||
| ts = Timestamp('1985-09-02 23:57:46.232550356-0300', |
There was a problem hiding this comment.
Reference your PR as a comment. Same for all other tests that you added.
|
https://travis-ci.org/pandas-dev/pandas/jobs/324352177 Not sure why this keeps timing out. |
| @apply_wraps | ||
| def apply(self, other): | ||
| base = other | ||
| # Note: self.n == 0 is not allowed. |
There was a problem hiding this comment.
This is enforced in init.
pandas/tseries/offsets.py
Outdated
| @@ -1951,7 +1941,7 @@ class FY5253Quarter(DateOffset): | |||
| or 14 week when needed. {1,2,3,4} | |||
| variation : str | |||
| {"nearest", "last"} for "LastOfMonth" or "NearestEndMonth" | |||
| """ | |||
| """ % _5253doc | |||
There was a problem hiding this comment.
and same on all the templates (generally we want to always use the .format())
There was a problem hiding this comment.
That was the first attempt. That syntax doesn't play nicely with the set syntax inside the docstring. The docstring change here is tangential to the PR; I'll just revert it.
pandas/tseries/offsets.py
Outdated
|
|
||
| Returns | ||
| ------- | ||
| prev_year_end : Timestamp giving most recent fiscal year end |
|
Ping |
|
thanks! |
Similar to [need to lookup reference], this fixes bugs in
LastWeekOfMonthandFY5253Quarterto ensure that the fast implementationoffset.onOffset(ts)matches the slow (base class) implementation(ts + offset) - offset == ts.I haven't yet looked at BusinessHour and CustomBusinessHour, but other than that I think these are the last classes that have this category of bug.
git diff upstream/master -u -- "*.py" | flake8 --diff