DOC: add source activate for older versions of Anaconda and fix a typo
#19282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jan 18, 2018
doc/source/contributing.rst
Outdated
| @@ -170,7 +170,7 @@ We'll now kick off a three-step process: | |||
|
|
|||
| # Create and activate the build environment | |||
| conda env create -f ci/environment-dev.yaml | |||
| conda activate pandas-dev | |||
| source activate pandas-dev | |||
There was a problem hiding this comment.
note that conda activate is not actually a typo, you just do this in newer versions of conda. can you update so both are here? (its ok that source activate is the primary).
There was a problem hiding this comment.
I stand corrected-- looks like conda activate was added around version 4.4.
del82
force-pushed
the
contribution-docs-typos
branch
from
36d1b0f to
2c08412
Compare
del82
changed the title
source activate for older versions of Anaconda and fix a typo
jreback
reviewed
Jan 18, 2018
doc/source/contributing.rst
Outdated
| @@ -171,6 +171,8 @@ We'll now kick off a three-step process: | |||
| # Create and activate the build environment | |||
| conda env create -f ci/environment-dev.yaml | |||
| conda activate pandas-dev | |||
| # or with older versions of Anaconda: | |||
There was a problem hiding this comment.
can you add a blank line here, otherwise lgtm.
Codecov Report
@@ Coverage Diff @@
## master #19282 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 148 148
Lines 48870 48870
=======================================
Hits 44737 44737
Misses 4133 4133
Continue to review full report at Codecov.
|
jorisvandenbossche
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the contrib docs,
conda activateshould besource activate, and there was also an extraneous period after the "continuous integration" heading.