Clear up confusion from #19411 #19554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19554 +/- ##
=======================================
Coverage 91.93% 91.93%
=======================================
Files 159 159
Lines 49733 49733
=======================================
Hits 45721 45721
Misses 4012 4012
Continue to review full report at Codecov.
|
jreback
requested changes
Feb 6, 2018
pandas/util/testing.py
Outdated
| @@ -1215,6 +1215,10 @@ def assert_frame_equal(left, right, check_dtype=True, | |||
| obj='DataFrame'): | |||
| """Check that left and right DataFrame are equal. | |||
|
|
|||
| Each element at [row, column] in left is compared to the | |||
| element at [row, column] in right (index and column values | |||
There was a problem hiding this comment.
this last part of the comment adds to confusion. can you clarify. Maybe add this to a Notes section
There was a problem hiding this comment.
I moved the clarification into the parameter description.
|
@darcymeyer can you update? |
@TomAugspurger : Sure can 🙂 |
Explicitly state that the `names` attribute of `DataFrame.index` and `DataFrame.columns` are being compared. Closes pandas-devgh-19411.
|
@jreback @TomAugspurger : All is green and rebased. PTAL. |
jreback
approved these changes
Jul 6, 2018
|
thanks @gfyoung |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Explicitly state that the `names` attribute of `DataFrame.index` and `DataFrame.columns` are being compared. Closes pandas-devgh-19411.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify docstring for pandas.util.testing.assert_frame_equal
closes #19411