Implement get_day_of_year, tests

[jbrockmendel]

Separates the ccalendar.get_day_of_year part out of #18540, implements tests, uses it in Timestamp renders Timestamp._get_field unnecessary.

[pep8speaks]

Hello @jbrockmendel! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 07, 2018 at 00:34 Hours UTC

[codecov]

Codecov Report

Merging #19555 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #19555      +/-   ##
==========================================
+ Coverage    91.6%   91.63%   +0.02%     
==========================================
  Files         150      150              
  Lines       48750    48750              
==========================================
+ Hits        44657    44670      +13     
+ Misses       4093     4080      -13

Flag	Coverage Δ
#multiple	90% <100%> (+0.02%)	⬆️
#single	41.75% <0%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/core/indexes/datetimes.py	95.25% <100%> (ø)	⬆️
pandas/io/parsers.py	95.56% <0%> (+0.06%)	⬆️
pandas/plotting/_converter.py	66.95% <0%> (+1.73%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c86aa...5b11a2a. Read the comment docs.

[jreback]

ok! love things that consolidate utilities