-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC/API: expose ExtensionArray in public api #20795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC/API: expose ExtensionArray in public api #20795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should indeed do this.
doc/source/extending.rst
Outdated
@@ -79,10 +79,10 @@ on :ref:`ecosystem.extensions`. | |||
|
|||
The interface consists of two classes. | |||
|
|||
``ExtensionDtype`` | |||
^^^^^^^^^^^^^^^^^^ | |||
:class:`pandas.api.extension.ExtensionDtype` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a ~
in the title link (to only show ExtensionDtype), or in the link in the text. (using the full link once is enough I think?)
Codecov Report
@@ Coverage Diff @@
## master #20795 +/- ##
==========================================
- Coverage 91.85% 91.82% -0.03%
==========================================
Files 153 153
Lines 49310 49319 +9
==========================================
- Hits 45292 45286 -6
- Misses 4018 4033 +15
Continue to review full report at Codecov.
|
Thanks! |
cc @jorisvandenbossche do you want to include these in the public API docs? It's nice to have a place to link to I think.