Skip to content

DOC/API: expose ExtensionArray in public api #20795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2018

Conversation

TomAugspurger
Copy link
Contributor

cc @jorisvandenbossche do you want to include these in the public API docs? It's nice to have a place to link to I think.

@TomAugspurger TomAugspurger added Docs ExtensionArray Extending pandas with custom dtypes or arrays. labels Apr 23, 2018
@TomAugspurger TomAugspurger added this to the 0.23.0 milestone Apr 23, 2018
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should indeed do this.

@@ -79,10 +79,10 @@ on :ref:`ecosystem.extensions`.

The interface consists of two classes.

``ExtensionDtype``
^^^^^^^^^^^^^^^^^^
:class:`pandas.api.extension.ExtensionDtype`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a ~ in the title link (to only show ExtensionDtype), or in the link in the text. (using the full link once is enough I think?)

@codecov
Copy link

codecov bot commented Apr 23, 2018

Codecov Report

Merging #20795 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20795      +/-   ##
==========================================
- Coverage   91.85%   91.82%   -0.03%     
==========================================
  Files         153      153              
  Lines       49310    49319       +9     
==========================================
- Hits        45292    45286       -6     
- Misses       4018     4033      +15
Flag Coverage Δ
#multiple 90.21% <100%> (-0.03%) ⬇️
#single 41.89% <75%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/base.py 84.14% <ø> (ø) ⬆️
pandas/core/common.py 92.01% <100%> (-0.03%) ⬇️
pandas/api/extensions/__init__.py 100% <100%> (ø) ⬆️
pandas/plotting/_converter.py 65.07% <0%> (-1.74%) ⬇️
pandas/util/testing.py 84.59% <0%> (-0.21%) ⬇️
pandas/core/indexes/base.py 96.63% <0%> (-0.05%) ⬇️
pandas/core/indexes/multi.py 95.07% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e77b0...fc3dfaa. Read the comment docs.

@jorisvandenbossche jorisvandenbossche changed the title Ea public api DOC/API: expose ExtensionArray in public api Apr 24, 2018
@jorisvandenbossche jorisvandenbossche merged commit 3f3e92f into pandas-dev:master Apr 24, 2018
@jorisvandenbossche
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants