Base Index Tests Cleanup Part 3 #20931
Conversation
| index = Index([' jack', 'jill ', ' jesse ', 'frank']) | ||
| expected = Index([getattr(str, method)(x) for x in index.values]) | ||
|
|
||
| result = getattr(index.str, method)() |
There was a problem hiding this comment.
I suppose the call signature here is different than what was previously in the test but I don't think that this should have any arguments (?)
| tm.assert_numpy_array_equal(result, expected) | ||
| assert isinstance(result, np.ndarray) | ||
|
|
||
| def test_str_bool_series_indexing(self): |
There was a problem hiding this comment.
I split this test up, but conceptually do we even want / need this here? Seems like it would be better placed in the Series modules if even required
There was a problem hiding this comment.
yes, feel free to move tests as appropriate (can be followups to make diffs easier)
Codecov Report
@@ Coverage Diff @@
## master #20931 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 153 153
Lines 49478 49478
=======================================
Hits 45429 45429
Misses 4049 4049
Continue to review full report at Codecov.
|
| with pytest.raises(KeyError): | ||
| idx.get_loc(1.1, method, tolerance=0.05) | ||
|
|
||
| @pytest.mark.parametrize("method", [None, 'pad', 'backfill', 'nearest']) |
There was a problem hiding this comment.
could makes these a fixture as well (maybe fill_names_fixture)
| tm.assert_numpy_array_equal(result, expected) | ||
| assert isinstance(result, np.ndarray) | ||
|
|
||
| def test_str_bool_series_indexing(self): |
There was a problem hiding this comment.
yes, feel free to move tests as appropriate (can be followups to make diffs easier)
jreback
added
Testing
|
thanks ! |
progress towards #20812