-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Support for OO Optimization #21093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OO Optimization #21093
Changes from 2 commits
840eec8
19e71e3
95826d3
0e48c18
2248137
abdc5f2
e4ba948
021786b
a1b409d
a89c4f4
078610a
91a2226
c697dae
d6c66ec
c853c67
c825636
f8ccfa0
e427f4b
46a2f6a
a2e748a
75dbaad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1090,12 +1090,15 @@ def apply(self, other): | |
|
||
|
||
class CustomBusinessMonthEnd(_CustomBusinessMonth): | ||
__doc__ = _CustomBusinessMonth.__doc__.replace('[BEGIN/END]', 'end') | ||
if _CustomBusinessMonth.__doc__: | ||
__doc__ = _CustomBusinessMonth.__doc__.replace('[BEGIN/END]', 'end') | ||
_prefix = 'CBM' | ||
|
||
|
||
class CustomBusinessMonthBegin(_CustomBusinessMonth): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think better to do this with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense - I'll take a look and repush |
||
__doc__ = _CustomBusinessMonth.__doc__.replace('[BEGIN/END]', 'beginning') | ||
if _CustomBusinessMonth.__doc__: | ||
__doc__ = _CustomBusinessMonth.__doc__.replace('[BEGIN/END]', | ||
'beginning') | ||
_prefix = 'CBMS' | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove the "xarray" here, as it is generally useful to ensure this, not only for xarray