Skip to content

fixes #22085 (int type pandas.series.index contains float type key bug) #22366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fixes #22085 (int type pandas.series.index contains float type key bug) #22366

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2307d22
fixes #22085
a1shadows Aug 15, 2018
75506e9
changes added
a1shadows Aug 16, 2018
392335d
code block placed outside try statement
a1shadows Aug 16, 2018
ae5796b
minor indentation adjustment
a1shadows Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1949,6 +1949,9 @@ def __nonzero__(self):
def __contains__(self, key):
hash(key)
try:
if type(key) == float and self.dtype == int:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use is_float(key) and is_integer_dtype(self.dtype)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I'm very new to this. But could you please tell me what to add to whatsnew,

if key != int(key):
return False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this outside of the try/except block

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorisvandenbossche I think it can't pass the test!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it fails when key is NaN ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. The block is needed.

return key in self._engine
except (OverflowError, TypeError, ValueError):
return False
Expand Down