Skip to content

TST: Streaming of S3 files #22520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2018
Merged

TST: Streaming of S3 files #22520

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
901837f
adding new botocore - allows for streaming
kokes Aug 27, 2018
0b74701
testing streaming of CSV files from S3
kokes Aug 27, 2018
86cc36b
skip test if botocore not installed
kokes Aug 27, 2018
16d92aa
reverting addition of a dependency
kokes Aug 27, 2018
14634b1
test docstring
kokes Aug 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions pandas/tests/io/test_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
import pytest

from pandas import read_csv
from pandas.compat import BytesIO
from pandas.io.common import is_s3_url


Expand All @@ -6,3 +10,16 @@ class TestS3URL(object):
def test_is_s3_url(self):
assert is_s3_url("s3://pandas/somethingelse.com")
assert not is_s3_url("s4://pandas/somethingelse.com")


def test_streaming_s3_objects():
pytest.importorskip('botocore', minversion='1.10.47')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the issue number here as a comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, done

from botocore.response import StreamingBody

data = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then here you can do botocore_response = pytest.importorskip('botocore.response', minversion='1.10.47')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this when the version pertains to the base module, not the imported class? I just tried it in a dummy file and all I got was Skipped: module 'botocore.response' has __version__ None, required is: '1.10.47'. So should I do something like this?

import pytest

def my_test_fn():
    pytest.importorskip('botocore', minversion='1.10.47')
    from botocore.response import StreamingBody
    # test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, your suggestion should work.

b'foo,bar,baz\n1,2,3\n4,5,6\n',
b'just,the,header\n',
]
for el in data:
body = StreamingBody(BytesIO(el), content_length=len(el))
read_csv(body)