Skip to content

CLN: Merge_asof null error message #23195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Oct 17, 2018

  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Post #23190 cleanup based on a review I wanted to give:

  • any() instead of sum() > 0
  • pytest parametrize

cc @jreback

@pep8speaks
Copy link

Hello @mroeschke! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #23195 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23195   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         169      169           
  Lines       50964    50964           
=======================================
  Hits        46985    46985           
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.61% <100%> (ø) ⬆️
#single 42.29% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/reshape/merge.py 93.94% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd863d3...b8e3f92. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Oct 17, 2018
@jreback
Copy link
Contributor

jreback commented Oct 17, 2018

thanks @mroeschke

@jreback jreback merged commit 85ec457 into pandas-dev:master Oct 17, 2018
@mroeschke mroeschke deleted the merge_asof_followup branch October 17, 2018 16:08
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants