Skip to content

CLN GH23204 remove "not" typo in assertion #23221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

rdmontgomery
Copy link
Contributor

@rdmontgomery rdmontgomery commented Oct 18, 2018

Remove an unwanted "not" in the assertion message.

This is my first pandas PR! Let me know if there's anything else I need to do. Thanks!

@pep8speaks
Copy link

Hello @rdmontgomery! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #23221 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23221   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         169      169           
  Lines       50962    50962           
=======================================
  Hits        46984    46984           
  Misses       3978     3978
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 42.26% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/reshape/concat.py 97.6% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6030452...eb0ff3f. Read the comment docs.

@jreback jreback added the Error Reporting Incorrect or improved errors from pandas label Oct 23, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 23, 2018
@jreback jreback merged commit 9308c7c into pandas-dev:master Oct 23, 2018
@jreback
Copy link
Contributor

jreback commented Oct 23, 2018

thanks!

jorisvandenbossche added a commit that referenced this pull request Oct 23, 2018
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Oct 23, 2018
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading "not" typo in assertion in pandas.concat in join_axes check
3 participants