-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: fix HDFStore.append with all empty strings error (GH12242) #23435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1441,6 +1441,15 @@ def check_col(key, name, size): | |
result = store.select('df') | ||
tm.assert_frame_equal(result, df) | ||
|
||
# with all empty strings (GH 12242) | ||
_maybe_remove(store, 'df') | ||
df1 = DataFrame({'x': list('abcdef')}) | ||
df2 = DataFrame({'x': ['']}) | ||
store.append('df', df1, min_itemsize={'x': 1}) | ||
store.append('df', df2, min_itemsize={'x': 1}) | ||
tm.assert_frame_equal(store.select('df'), | ||
pd.concat([df1, df2])) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of comparing to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you push this to a new test, the existing ones are really long already |
||
|
||
with ensure_clean_store(self.path) as store: | ||
|
||
def check_col(key, name, size): | ||
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double backticks around
min_itemsize