-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TST: use s3_resource fixture consistently #24073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @h-vetinari! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #24073 +/- ##
=======================================
Coverage 42.51% 42.51%
=======================================
Files 161 161
Lines 51689 51689
=======================================
Hits 21974 21974
Misses 29715 29715
Continue to review full report at Codecov.
|
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #24073 +/- ##
=======================================
Coverage 42.51% 42.51%
=======================================
Files 161 161
Lines 51689 51689
=======================================
Hits 21974 21974
Misses 29715 29715
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24073 +/- ##
=======================================
Coverage 42.51% 42.51%
=======================================
Files 161 161
Lines 51689 51689
=======================================
Hits 21974 21974
Misses 29715 29715
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24073 +/- ##
=======================================
Coverage 42.51% 42.51%
=======================================
Files 161 161
Lines 51689 51689
=======================================
Hits 21974 21974
Misses 29715 29715
Continue to review full report at Codecov.
|
thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diff
There are two boto tests that are not using the dedicated
s3_resource
fixture which takes care of all the mocking etc. This PR adapts those tests accordingly, which also allows unified treatment of things like #23754.