Skip to content

DOC: Fix visualization.rst flake8 issues #24186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2018

Conversation

addisonlynch
Copy link
Contributor

@addisonlynch addisonlynch commented Dec 9, 2018

Removes a number of trailing whitespaces as well

@datapythonista datapythonista changed the title Repair visualization.rst flake8 issues, remove exclusion from config DOC: Fix visualization.rst flake8 issues Dec 9, 2018
@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #24186 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24186   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         162      162           
  Lines       51723    51723           
=======================================
  Hits        47694    47694           
  Misses       4029     4029
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 43.03% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/datetimes.py 98.56% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7dbe0...7e3309d. Read the comment docs.

@datapythonista
Copy link
Member

Sorry I wasn't clear, but do you mind removing it from the previous cell?

Lines shouldn't end in semicolon, the only case where we use them is in the last line of a block that returns a block. Without the semicolon, besides displaying the plot, it shows the plot object, which doesn't look great.

@addisonlynch
Copy link
Contributor Author

@datapythonista sorry about that -- misunderstood what you had said. Removed the first semicolon.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @addisonlynch

@jreback jreback added this to the 0.24.0 milestone Dec 10, 2018
@jreback jreback merged commit 2049c03 into pandas-dev:master Dec 10, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Fix flake8 issues in doc/source/visualization.rst
3 participants