-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
DOC: Fix visualization.rst flake8 issues #24186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix visualization.rst flake8 issues #24186
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24186 +/- ##
=======================================
Coverage 92.21% 92.21%
=======================================
Files 162 162
Lines 51723 51723
=======================================
Hits 47694 47694
Misses 4029 4029
Continue to review full report at Codecov.
|
Sorry I wasn't clear, but do you mind removing it from the previous cell? Lines shouldn't end in semicolon, the only case where we use them is in the last line of a block that returns a block. Without the semicolon, besides displaying the plot, it shows the plot object, which doesn't look great. |
@datapythonista sorry about that -- misunderstood what you had said. Removed the first semicolon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @addisonlynch
Removes a number of trailing whitespaces as well
git diff upstream/master -u -- "*.py" | flake8 --diff