Skip to content

CLN: remove compat.iteritems #26079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Apr 13, 2019

Removes compat.iteritems.

@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@190a69e). Click here to learn what that means.
The diff coverage is 21.87%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #26079   +/-   ##
=========================================
  Coverage          ?   40.74%           
=========================================
  Files             ?      175           
  Lines             ?    52505           
  Branches          ?        0           
=========================================
  Hits              ?    21394           
  Misses            ?    31111           
  Partials          ?        0
Flag Coverage Δ
#single 40.74% <21.87%> (?)
Impacted Files Coverage Δ
pandas/io/packers.py 14.53% <ø> (ø)
pandas/compat/__init__.py 69.73% <ø> (ø)
pandas/core/base.py 33.92% <0%> (ø)
pandas/util/testing.py 48.26% <0%> (ø)
pandas/core/arrays/categorical.py 41.43% <0%> (ø)
pandas/core/computation/align.py 18.47% <0%> (ø)
pandas/core/groupby/groupby.py 24.48% <0%> (ø)
pandas/util/_doctools.py 12.87% <0%> (ø)
pandas/core/generic.py 37.84% <0%> (ø)
pandas/core/reshape/melt.py 13.33% <0%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190a69e...798fa45. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@190a69e). Click here to learn what that means.
The diff coverage is 89.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #26079   +/-   ##
=========================================
  Coverage          ?   91.94%           
=========================================
  Files             ?      175           
  Lines             ?    52430           
  Branches          ?        0           
=========================================
  Hits              ?    48207           
  Misses            ?     4223           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.5% <87.69%> (?)
#single 40.73% <23.07%> (?)
Impacted Files Coverage Δ
pandas/io/packers.py 88.08% <ø> (ø)
pandas/compat/__init__.py 93.1% <ø> (ø)
pandas/util/_doctools.py 12% <0%> (ø)
pandas/plotting/_core.py 83.76% <0%> (ø)
pandas/core/base.py 97.99% <100%> (ø)
pandas/util/testing.py 90.61% <100%> (ø)
pandas/io/html.py 92.64% <100%> (ø)
pandas/core/arrays/categorical.py 95.96% <100%> (ø)
pandas/core/computation/align.py 97.8% <100%> (ø)
pandas/core/groupby/groupby.py 97.22% <100%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190a69e...1662318. Read the comment docs.

@topper-123 topper-123 force-pushed the cln_iteritems branch 5 times, most recently from bed5c3e to b02935e Compare April 14, 2019 07:37
@topper-123
Copy link
Contributor Author

The Travis error is a ResourceWarning: ResourceWarning: unclosed file <_io.TextIOWrapper name=0 mode='r' encoding='UTF-8'>, All other stuff passes.

@gfyoung gfyoung added this to the 0.25.0 milestone Apr 15, 2019
@gfyoung gfyoung merged commit e26e2df into pandas-dev:master Apr 15, 2019
@gfyoung
Copy link
Member

gfyoung commented Apr 15, 2019

Thanks @topper-123 !

@topper-123 topper-123 deleted the cln_iteritems branch April 15, 2019 22:22
yhaque1213 pushed a commit to yhaque1213/pandas that referenced this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants