fixes qcut failing for labels = True

[Dharni0607]

• closes qcut fails with labels=True #26963

[Dharni0607]

@WillAyd, This is my first pull request, please review and let me know if anything needs to be changed. Thanks :-)

[WillAyd]

Hi @Dharni0607 - thanks for the PR. The most critical part of any PR is a test case which ensures that the change is working as intended which we don't have here, so would be a good idea to start with that.

You would want to give the contributing guide a read as it will give you good instructions on how to go about the process

https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#contributing-to-pandas

[Dharni0607]

Thanks @WillAyd, I will refer it and add required tests.

[codecov]

Codecov Report

Merging #27033 into master will decrease coverage by 50.14%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           master   #27033       +/-   ##
===========================================
- Coverage   91.99%   41.85%   -50.15%     
===========================================
  Files         180      180               
  Lines       50774    50774               
===========================================
- Hits        46711    21251    -25460     
- Misses       4063    29523    +25460

Flag	Coverage Δ
#multiple	?
#single	41.85% <66.66%> (-0.07%)	⬇️

Impacted Files	Coverage Δ
pandas/core/reshape/tile.py	11.04% <66.66%> (-86.63%)	⬇️
pandas/io/formats/latex.py	0% <0%> (-100%)	⬇️
pandas/io/gcs.py	0% <0%> (-100%)	⬇️
pandas/io/sas/sas_constants.py	0% <0%> (-100%)	⬇️
pandas/core/groupby/categorical.py	0% <0%> (-100%)	⬇️
pandas/tseries/plotting.py	0% <0%> (-100%)	⬇️
pandas/tseries/converter.py	0% <0%> (-100%)	⬇️
pandas/io/s3.py	0% <0%> (-100%)	⬇️
pandas/io/formats/html.py	0% <0%> (-99.37%)	⬇️
pandas/io/sas/sas7bdat.py	0% <0%> (-91.16%)	⬇️
... and 133 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea2d08...e49cf70. Read the comment docs.

[codecov]

Codecov Report

Merging #27033 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #27033      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.01%     
==========================================
  Files         180      180              
  Lines       50714    50714              
==========================================
- Hits        46679    46675       -4     
- Misses       4035     4039       +4

Flag	Coverage Δ
#multiple	90.67% <100%> (ø)	⬆️
#single	41.86% <0%> (-0.09%)	⬇️

Impacted Files	Coverage Δ
pandas/core/reshape/tile.py	97.67% <100%> (ø)	⬆️
pandas/io/gbq.py	88.88% <0%> (-11.12%)	⬇️
pandas/core/frame.py	96.89% <0%> (-0.12%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e955515...657d44a. Read the comment docs.

[pep8speaks]

Hello @Dharni0607! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-27 08:26:51 UTC

[Dharni0607]

I am not able to figure out why exactly the codecov has decreased. Can someone help, so that I can work on it.

[jreback]

the coverage is not relevant it gives weird results.

but more importantly, I think this needs discusion as this gives really weird semantics.

[jreback]

needs discussion

[WillAyd]

Thanks for the PR @Dharni0607 . I think for now though this has gone stale and needs discussion anyway, so going to close to keep our PR queue clean. If interested in going further let's move discussion back to associated issue

Thanks again!