-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: Fix insertion of wrong-dtypes NaT into Series[m8ns] #27323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
24a0149
Fix+test wrong-dtype nat assigned to Series
jbrockmendel 0e4de03
rename test
jbrockmendel e26875b
Merge branch 'master' of https://github.com/pandas-dev/pandas into wr…
jbrockmendel 80a558d
catch ValueError bc it comes up in some builds
jbrockmendel 0114dcd
Merge branch 'master' of https://github.com/pandas-dev/pandas into wr…
jbrockmendel e4e9dde
Merge branch 'master' of https://github.com/pandas-dev/pandas into wr…
jbrockmendel 8de3b74
change test class to func
jbrockmendel 8592772
Merge branch 'master' of https://github.com/pandas-dev/pandas into wr…
jbrockmendel f101db7
use is_valid_nat_for_dtype
jbrockmendel bebcedb
isort fixup
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -544,6 +544,10 @@ cpdef convert_scalar(ndarray arr, object value): | |
pass | ||
elif isinstance(value, timedelta): | ||
return Timedelta(value).value | ||
elif util.is_datetime64_object(value): | ||
# exclude np.datetime64("NaT") which would otherwise be picked up | ||
# by the `value != value check below | ||
pass | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. really everything from 531 down to 555 should be ripped out and this handled by the DatetimeArray/TimedeltaArray |
||
elif value is None or value != value: | ||
return NPY_NAT | ||
elif isinstance(value, str): | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.